nightly: fix masternode identities and other fixes. - #992
Merged
Conversation
lklimek
requested changes
Apr 28, 2023
| seconds: (time_ms / 1000) as i64, | ||
| nanos: ((time_ms % 1000) * 1000) as i32, | ||
| }), | ||
| next_validators_hash: vec![], |
Contributor
There was a problem hiding this comment.
next_validators_hash is required and must have 32 bytes
Member
Author
There was a problem hiding this comment.
okay, I'll put a random number for now.
| pub(crate) fn update_core_info( | ||
| &self, | ||
| state: &mut PlatformState, | ||
| platform_state: Option<&PlatformState>, |
Contributor
There was a problem hiding this comment.
please update documentation above
| fn reverse(data: &[u8]) -> Vec<u8> { | ||
| let mut data = data.to_vec(); | ||
| data.reverse(); | ||
| // data.reverse(); |
Contributor
There was a problem hiding this comment.
we still have to reverse protxhash
Member
Author
There was a problem hiding this comment.
Let's do it right after in another PR right after, I'm afraid it will be a lot of changing of tests, and I have things green right now :)
markin-io
approved these changes
Apr 28, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
This PR mainly is a partial rewrite of masternode identities.
What was done?
It also adds to the mimic executor a phase for tenderdash process proposal after prepare proposal. This allows tests to be able get back the appropriate block hash and compare it on finalize block, as well as mimic real tenderdash execution.
There is also a refactoring of strategy tests into files.
How Has This Been Tested?
There is a new testing strategy that mimics a large amount of masternode and HPMN updates that get applied as the chain progresses.
Breaking Changes
Checklist:
For repository code-owners and collaborators only