test(e2e/mst): DESCRIBE QUERY is now allowed in transactions#836
Merged
Conversation
The server's MSTCheckRule allowlist has broadened to include DESCRIBE QUERY (DescribeQueryCommand), mirroring the earlier SHOW COLUMNS change. It no longer throws inside an active transaction, so the prior test_describe_query_blocked assertion (DID NOT RAISE) was stale. Flip it to test_describe_query_not_blocked using _assert_not_blocked (verifies it succeeds and returns >0 rows) and move DESCRIBE QUERY from the Blocked to the Allowed list in the class docstring. Verified against a live DBSQL warehouse: the full TestMstBlockedSql class (9 tests) passes. Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
vikrantpuppala
force-pushed
the
fix/mst-describe-query-allowed
branch
from
efbe647 to
0fe9ad9
Compare
msrathore-db
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The e2e test
TestMstBlockedSql::test_describe_query_blockedstarted failing in CI withFailed: DID NOT RAISE <class 'Exception'>. This is a server-side behavior change, not a connector regression: the server'sMSTCheckRuleallowlist has been broadened to includeDESCRIBE QUERY(DescribeQueryCommand), so it no longer throws inside an active multi-statement transaction.This mirrors the earlier
SHOW COLUMNSchange (#778), where a previously-blocked introspection statement became allowed and the test was flipped accordingly.Changes
test_describe_query_blocked->test_describe_query_not_blockedand switch it from_assert_blocked_and_txn_abortedto_assert_not_blocked(which verifies the statement succeeds and returns >0 rows inside the txn).TestMstBlockedSqldocstring: moveDESCRIBE QUERYfrom the Blocked list to the Allowed list.Testing
Verified against a live DBSQL warehouse:
test_describe_query_not_blocked- PASS (DESCRIBE QUERY succeeds in MST, returns rows)TestMstBlockedSqlclass (9 tests) - all PASS