chore(lint): migrate from tslint to eslint

.eslintignore

@@ -0,0 +1,10 @@
+# Dependencies and build outputs
+node_modules
+bazel-*
+dist
+tmp
+
+# Test fixture projects (mock dataform project fixtures)
+tests/api/projects/
+tests/integration/bigquery_project/
+tests/integration/property_graph_project/

.eslintrc.js

@@ -1,19 +1,53 @@
 /**
- * ESLint config for the Dataform CLI & Core repo.
- *
- * Scope: currently only used to enforce sandbox-safety rules in `core/`.
- * The rest of the codebase is still linted by tslint (see tslint.json).
- * Add ESLint rules here only when they need capabilities tslint 5.17 cannot
- * express (per-file `overrides`, per-message text, AST rules, etc.).
+ * ESLint config for the Dataform repository.
  */
 module.exports = {
   root: true,
+  ignorePatterns: [
+    'bazel-*',
+    'node_modules',
+    'tests/api/projects/**',
+    'tests/integration/*_project/**',
+  ],
   parser: '@typescript-eslint/parser',
   parserOptions: {
     ecmaVersion: 2020,
     sourceType: 'module',
   },
+  env: {
+    es2020: true,
+    node: true,
+  },
+  rules: {
+    'prefer-const': 'error',
+    'no-var': 'error',
+    'no-debugger': 'error',
+    'no-duplicate-imports': 'error',
+    'no-empty': ['error', { allowEmptyCatch: true }],
+    'curly': 'error',
+    'eqeqeq': ['error', 'smart'],
+    'no-unused-expressions': 'error',
+    'no-console': 'error',
+    'no-eval': 'error',
+    'no-throw-literal': 'error',
+    'radix': 'error',
+    'no-cond-assign': 'error',
+    'no-unsafe-finally': 'error',
+    'no-caller': 'error',
+    'use-isnan': 'error',
+    'no-self-assign': 'error',
+    'no-shadow-restricted-names': 'error',
+    'ordered-imports': 'error',
+    'no-new-func': 'error',
+  },
   overrides: [
+    {
+      // JIT compiler dynamically creates executable functions in the V8 sandbox
+      files: ['core/jit_compiler.ts'],
+      rules: {
+        'no-new-func': 'off',
+      },
+    },
     {
       // core/ runs inside the V8 compilation sandbox — no Node built-ins.
       files: ['core/**/*.ts'],
@@ -22,11 +56,26 @@ module.exports = {
       },
     },
     {
-      // Tests under core/ run on the host Node runtime, not in the sandbox,
-      // so they may legitimately use fs, path, etc. for fixture setup.
-      files: ['core/**/*_test.ts', 'core/**/*.test.ts'],
+      // Ambient declarations for webpack internals
+      files: ['core/utils.ts', 'core/workflow_settings.ts'],
+      rules: {
+        'no-var': 'off',
+      },
+    },
+    {
+      // Tests, testing helpers, examples, CLI console wrapper, VSCode extension, and common promises logger may use console
+      files: [
+        '**/*_test.ts',
+        '**/*.test.ts',
+        'testing/**/*.ts',
+        'examples/**/*.ts',
+        'cli/console.ts',
+        'vscode/**/*.ts',
+        'common/promises/index.ts',
+      ],
       rules: {
         'no-node-builtins': 'off',
+        'no-console': 'off',
       },
     },
   ],

BUILD

@@ -42,12 +42,14 @@ nodejs_binary(
 )
 
 nodejs_binary(
-    name = "tslint",
+    name = "eslint",
     data = [
-        "@npm//tslint",
-    ],
-    entry_point = "@npm//:node_modules/tslint/bin/tslint",
-    templated_args = ["--node_options=--preserve-symlinks"],
+        ".eslintrc.js",
+        ".eslintignore",
+        "@npm//@typescript-eslint/parser",
+        "@npm//eslint",
+    ] + glob(["eslint-rules/**"]),
+    entry_point = "@npm//:node_modules/eslint/bin/eslint.js",
 )
 
 load("@bazel_gazelle//:def.bzl", "gazelle")

cli/index_compile_test.ts

@@ -215,7 +215,6 @@ SELECT 1 as id
           schema: "dataform"
         },
         query:
-          // tslint:disable-next-line:tsr-detect-sql-literal-injection
           `\nSELECT\n  *\nFROM (\n  SELECT\n    id,\n    COUNT(1) AS index_row_count\n  FROM \`${INTEGRATION_TEST_PROJECT}.dataform.example_table\`\n  GROUP BY id\n  ) AS data\nWHERE index_row_count > 1\n`,
         target: {
           database: INTEGRATION_TEST_PROJECT,

cli/index_run_e2e_test.ts

@@ -111,7 +111,6 @@ select 1 as \${dataform.projectConfig.vars.testVar2}
     );
 
     if (runResult.exitCode !== 0 || runResult.stdout.trim().length === 0) {
-      // tslint:disable-next-line:no-console
       console.error("GOLDEN PATH FAILED. STDERR:", runResult.stderr);
     }
     expect(runResult.exitCode).equals(0);
@@ -130,7 +129,6 @@ select 1 as \${dataform.projectConfig.vars.testVar2}
           tasks: [
             {
               statement:
-                // tslint:disable-next-line:tsr-detect-sql-literal-injection
                 `create or replace table \`${INTEGRATION_TEST_PROJECT}.dataform.example\` as \n\nselect 1 as testValue2`,
               type: "statement"
             }
@@ -204,7 +202,6 @@ SELECT 1 as id
           tasks: [
             {
               statement:
-                // tslint:disable-next-line:tsr-detect-sql-literal-injection
                 `create or replace table \`${INTEGRATION_TEST_PROJECT}.dataform.example_table\` as \n\nSELECT 1 as id`,
               type: "statement"
             }
@@ -255,7 +252,6 @@ SELECT 1 as id
       );
 
       if (runResult.exitCode !== 0 || runResult.stdout.trim().length === 0) {
-        // tslint:disable-next-line:no-console
         console.error("ASSERTIONS TEST FAILED. STDERR:", runResult.stderr);
       }
       expect(runResult.exitCode).equals(0);
@@ -278,7 +274,6 @@ SELECT 1 as id
       );
 
       if (runResult.exitCode !== 0 || runResult.stdout.trim().length === 0) {
-        // tslint:disable-next-line:no-console
         console.error("ASSERTIONS TEST FAILED. STDERR:", runResult.stderr);
       }
       expect(runResult.exitCode).equals(0);
@@ -303,7 +298,6 @@ SELECT 1 as id
       );
 
       if (runResult.exitCode !== 0 || runResult.stdout.trim().length === 0) {
-        // tslint:disable-next-line:no-console
         console.error("ASSERTIONS TEST FAILED. STDERR:", runResult.stderr);
       }
       expect(runResult.exitCode).equals(0);

cli/index_test_base.ts

@@ -1,4 +1,3 @@
-// tslint:disable tsr-detect-non-literal-fs-filename
 import { execFile, ExecFileOptions } from "child_process";
 import * as fs from "fs-extra";
 import { dump as dumpYaml, load as loadYaml } from "js-yaml";

cli/tests/jit/jit_run_test.ts

@@ -341,14 +341,12 @@ suite("run", () => {
     const [executedSql] = capture(mockAdapter.execute).last();
     // For BigQuery, it should be an 'insert into' because no uniqueKey was specified.
     // We check for substrings without trailing spaces to avoid exact whitespace mismatches.
-    // tslint:disable: tsr-detect-sql-literal-injection
     expect(executedSql).to.equal(
       "insert into `db.sch.incremental_jit`	\n" +
       "(`t`)	\n" +
       "select `t`	\n" +
       "from (SELECT 'inc' as t) as insertions"
     );
-    // tslint:enable: tsr-detect-sql-literal-injection
   });
 
   test("JiT compilation with RPC calls (ListTables, GetTable, DeleteTable)", async () => {

common/promises/index.ts

@@ -1,5 +1,4 @@
 export function runAsyncIgnoringErrors(promise: Promise<any>) {
-  // tslint:disable-next-line: no-console
   promise.catch(e => console.error(`runAsyncIgnoringErrors caught error: ${e}`));
 }
 

common/strings/index.ts

@@ -7,7 +7,6 @@ export function timingSafeEqual(a: string, b: string) {
   }
 
   for (let i = 0; i < a.length; i++) {
-    // tslint:disable-next-line: no-bitwise
     result |= a.charCodeAt(i) ^ b.charCodeAt(i);
   }
 

core/actions/assertion_test.ts

@@ -1,4 +1,3 @@
-// tslint:disable tsr-detect-non-literal-fs-filename
 import { expect } from "chai";
 import * as fs from "fs-extra";
 import { dump as dumpYaml } from "js-yaml";

core/actions/data_preparation_test.ts

@@ -1,4 +1,3 @@
-// tslint:disable tsr-detect-non-literal-fs-filename
 import { expect } from "chai";
 import * as fs from "fs-extra";
 import { dump as dumpYaml, load as loadYaml } from "js-yaml";

core/actions/declaration_test.ts

@@ -1,4 +1,3 @@
-// tslint:disable tsr-detect-non-literal-fs-filename
 import { expect } from "chai";
 import * as fs from "fs-extra";
 import * as path from "path";

core/actions/filename_override_test.ts

@@ -1,4 +1,3 @@
-// tslint:disable tsr-detect-non-literal-fs-filename
 import { expect } from "chai";
 import * as fs from "fs-extra";
 import * as path from "path";

core/actions/incremental_table_test.ts

@@ -1,4 +1,3 @@
-// tslint:disable tsr-detect-non-literal-fs-filename
 import { expect } from "chai";
 import * as fs from "fs-extra";
 import * as path from "path";

core/actions/index_test.ts

@@ -1,4 +1,3 @@
-// tslint:disable tsr-detect-non-literal-fs-filename
 import { expect } from "chai";
 import * as fs from "fs-extra";
 import * as path from "path";

core/actions/notebook_test.ts

@@ -1,4 +1,3 @@
-// tslint:disable tsr-detect-non-literal-fs-filename
 import { expect } from "chai";
 import * as fs from "fs-extra";
 import * as path from "path";

core/actions/operation_test.ts

@@ -1,4 +1,3 @@
-// tslint:disable tsr-detect-non-literal-fs-filename
 import { expect } from "chai";
 import * as fs from "fs-extra";
 import * as path from "path";

core/actions/table_test.ts

@@ -1,4 +1,3 @@
-// tslint:disable tsr-detect-non-literal-fs-filename
 import { expect } from "chai";
 import * as fs from "fs-extra";
 import * as path from "path";

core/actions/test_test.ts

@@ -1,4 +1,3 @@
-// tslint:disable tsr-detect-non-literal-fs-filename
 import { expect } from "chai";
 import * as fs from "fs-extra";
 import * as path from "path";

core/actions/view_test.ts

@@ -1,4 +1,3 @@
-// tslint:disable tsr-detect-non-literal-fs-filename
 import { expect } from "chai";
 import * as fs from "fs-extra";
 import * as path from "path";

core/jit_compiler.ts

@@ -10,7 +10,6 @@ import { dataform } from "df/protos/ts";
 function makeMainBody<Context, T>(code: string): (jctx: JitContext<Context>) => Promise<T> {
   return (
     jctx => {
-      // tslint:disable-next-line: tsr-detect-eval-with-expression
       const body = new Function(
         "jctx", `const mainAsync = ${code};\nreturn mainAsync(jctx);`
       ) as (jctx: JitContext<Context>) => Promise<T>;

core/main.ts

@@ -210,7 +210,6 @@ function loadActionConfigsFile(
 ): dataform.ActionConfigs {
   let actionConfigsAsJson = {};
   try {
-    // tslint:disable-next-line: tsr-detect-non-literal-require
     actionConfigsAsJson = nativeRequire(actionConfigsPath).asJson;
   } catch (e) {
     session.compileError(e, actionConfigsPath);
@@ -252,7 +251,6 @@ function loadPropertyGraphs(session: Session, filePaths: string[]) {
   const graphPath = graphPaths[0];
   let configAsJson: any;
   try {
-    // tslint:disable-next-line: tsr-detect-non-literal-require
     configAsJson = snakeToCamelKeys(nativeRequire(graphPath).asJson);
   } catch (e) {
     session.compileError(e, graphPath);
@@ -313,7 +311,6 @@ function dataformCompile(compileRequest: dataform.ICompileExecutionRequest, sess
     .filter(path => Path.fileExtension(path) === "js")
     .forEach(includePath => {
       try {
-        // tslint:disable-next-line: tsr-detect-non-literal-require
         topLevelIncludes[Path.basename(includePath)] = nativeRequire(includePath);
       } catch (e) {
         session.compileError(e, includePath);
@@ -341,7 +338,6 @@ function dataformCompile(compileRequest: dataform.ICompileExecutionRequest, sess
     .sort()
     .forEach(definitionPath => {
       try {
-        // tslint:disable-next-line: tsr-detect-non-literal-require
         nativeRequire(definitionPath);
       } catch (e) {
         session.compileError(e, definitionPath);

core/main_test.ts

@@ -1,4 +1,3 @@
-// tslint:disable tsr-detect-non-literal-fs-filename
 import { expect } from "chai";
 import * as fs from "fs-extra";
 import { dump as dumpYaml } from "js-yaml";

core/workflow_settings.ts

@@ -81,7 +81,6 @@ function verifyWorkflowSettingsAsJson(workflowSettingsAsJson: object): dataform.
 
 function maybeRequire(file: string): any {
   try {
-    // tslint:disable-next-line: tsr-detect-non-literal-require
     return nativeRequire(file);
   } catch (e) {
     if (e instanceof SyntaxError || e instanceof YAMLException) {