Repository navigation
Mitigate core/index_compile_test timeouts - #2308
Merged
Merged
Conversation
|
|
||
| ["package.json", "package-lock.json", "node_modules"].forEach(npmFile => { | ||
| test(`compile throws an error when dataformCoreVersion in workflow_settings.yaml and ${npmFile} is present`, async () => { | ||
| test("compile rejects @dataform/core with incompatible version", { timeout : 60000 }, async () => { |
Collaborator
There was a problem hiding this comment.
The space after timeout should not be there, but linter should have done that.
Can you take a quick look at a linter, and why it didn't fix it?
Collaborator
Author
There was a problem hiding this comment.
Yes I'll take a look
| expect(stderr).contains("Set `dataformCoreVersion:"); | ||
| }); | ||
|
|
||
| test("compile succeeds with @dataform/core <= 3.0.56 via caller-file shim", { timeout : 60000 }, async () => { |
Collaborator
There was a problem hiding this comment.
Same here (as below).
…ts for some tests
Ford544
force-pushed
the
test-timeout-fix
branch
from
September 14, 2026 11:55
2803705 to
7077852
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the tests in core/index_compile_test often timeout when running ./scripts/run_tests