Repository navigation
Add a binary run test - #2356
Merged
Merged
Conversation
apilaskowski
approved these changes
Oct 5, 2026
apilaskowski
requested changes
Oct 8, 2026
apilaskowski
left a comment
apilaskowski
left a comment
Collaborator
There was a problem hiding this comment.
There is a HUGE list of conflicts now, please take care of those after previous PR is fixed.
Collaborator
Author
|
Rebased, no more merge conflicts |
apilaskowski
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a test running the CLI bundle directly (without specifying Node as the executor). This catches errors with malformed shebang line (which is ignored by Node but causes errors on direct invocation - such as when a user installs downloads the cli package from npm registry and tries to run dataform).
Example failure path: in packages/index.bzl, break the shebang by changing "#!/usr/bin/env node\n" to "#!/usr/bin/env node\\n" (extra backslash). All other tests pass, but the bundle fails with:
env: ‘node\n// Copyright 2023 Google LLC’: No such file or directory
env: use -[v]S to pass options in shebang lines