Skip to content

Update TypeScript, ts-eslint and rollup - #2365

Merged
Ford544 merged 1 commit into
mainfrom
ts-eslint-upgrade
Oct 12, 2026
Merged

Ford544 merged 1 commit into
mainfrom
ts-eslint-upgrade

Conversation

@Ford544

@Ford544 Ford544 commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator
  • Align TypeScript to 5.5.4 everywhere
    • typescript in package.json pinned to 5.5.4 (was ^3.8.3)
    • rules_ts now reads the version from the lockfile (ts_version_from = "@npm//:typescript/resolved.json") instead of a hard-coded ts_version
  • Upgrade rollup 2 → 3 and rollup-plugin-dts 1.4 → 6.4 (required for TS 5)
    • Rollup configs renamed to .mjs (rollup 3 no longer transpiles ESM configs)
  • Replace @typescript-eslint/parser v5 with typescript-eslint v8
    • Removed the ESLint 10 compatibility shim from eslint.config.js
    • Enabled type-aware linting (projectService)
    • //:eslint data updated to the new package
  • Restore promise checks dropped with tsetse
    • Enabled @typescript-eslint/no-floating-promises and @typescript-eslint/no-misused-promises (checksVoidReturn: false)
    • Fixed the two findings: promise-truthiness checks in cli/api/commands/run.ts and testing/runner.ts replaced with explicit undefined comparisons
  • Provide type information to ESLint in scripts/lint
    • Runs pnpm install --frozen-lockfile first (also fails CI on a stale lockfile)
    • Builds //protos:ts and //core:version, the generated sources df/* imports resolve to

@Ford544
Ford544 force-pushed the ts-eslint-upgrade branch from 1986c75 to 9959ef3 Compare October 9, 2026 09:26
@Ford544
Ford544 marked this pull request as ready for review October 9, 2026 09:38
@Ford544
Ford544 requested a review from a team as a code owner October 9, 2026 09:38
@Ford544
Ford544 requested review from Tuseeq1, apilaskowski and rafal-hawrylak and removed request for a team October 9, 2026 09:38
@Ford544
Ford544 force-pushed the bazel-aspect-rules branch from b4b2d7e to c68abe3 Compare October 12, 2026 07:31
@Ford544
Ford544 force-pushed the ts-eslint-upgrade branch 2 times, most recently from 1fdb278 to 6d29cc3 Compare October 12, 2026 09:37
Base automatically changed from bazel-aspect-rules to main October 12, 2026 09:53
@Ford544
Ford544 merged commit 4d05fd6 into main Oct 12, 2026
10 checks passed
@Ford544
Ford544 deleted the ts-eslint-upgrade branch October 12, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants