Repository navigation
Upgrade chokidar to v4 to drop vulnerable braces dependency - #2377
Merged
Merged
Conversation
chokidar 3.x depends on braces, which is affected by GHSA-vfj7-8cjw-p6xm (stack-exhaustion DoS, no patched version). chokidar 4 no longer depends on braces. Our usage (watch a directory, regex ignore) is v4-compatible. Also removes the now-unneeded braces override. Resolves Dependabot alert #384.
rafal-hawrylak
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Dependabot alert #384 (GHSA-vfj7-8cjw-p6xm:
braces <= 3.0.3stack-exhaustion DoS, no patched version available).Changes
chokidar^3.5.3→^4.0.3. chokidar v4 no longer depends onbraces(it also dropsanymatch,fill-range,picomatch, etc.).bracesoverride frompnpm.overrides, as nothing depends on it anymore.pnpm-lock.yamlregenerated with pnpm 9.7.1, the version pinned inMODULE.bazel. A few peer-dependency keys were also re-normalized by pnpm.Compatibility
chokidar is only used in
cli/commands/compile_command.ts(compile --watch) aswatch(projectDir, { ignored: /node_modules/, ... }). v4 removed glob support only, and a path plus a regexignoredare still supported.Testing
bazel build //cli/...✅dataform compile --watch