Repository navigation
fix(cli): remove unused sql and errorMessage OpenLineage facets - #2391
Merged
Merged
Conversation
The Data Lineage API ProcessOpenLineageRunEvent endpoint does not ingest job.facets.sql (SQLJobFacet) or run.facets.errorMessage (ErrorMessageRunFacet); Knowledge Catalog instead resolves the executed SQL query and job status from BigQuery via run.facets.externalQuery. Removing these unused facets avoids sending raw SQL text and task error messages in OpenLineage payloads and aligns the CLI payload builder with Cloud Dataform.
rafal-hawrylak
requested review from
apilaskowski
and removed request for
a team
October 20, 2026 08:15
mbiernacik
approved these changes
Oct 20, 2026
apilaskowski
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
job.facets.sql(SQLJobFacet) andrun.facets.errorMessage(ErrorMessageRunFacet) fromLineagePayloadBuilder.ProcessOpenLineageRunEventendpoint does not ingestsqlorerrorMessagefacets; Knowledge Catalog resolves the executed SQL query and job error status directly from BigQuery viarun.facets.externalQuery.Test Plan
./scripts/lint./scripts/run_tests./scripts/run_integration_tests