fix: display dynamic filters on FilterExec nodes - #760
Open
jayshrivastava wants to merge 1 commit into
Open
jayshrivastava wants to merge 1 commit into
jayshrivastava wants to merge 1 commit into
Conversation
Replay completed task predicates into isolated per-task display variants. Add SQL regression snapshots for local and cross-stage FilterExec consumers.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For dynamic filter consumers like
DistributedLeafExec, variants are implemented so we can store different copies of the node and render each variant at display time. For consumers likeFilterExec, we don't have variants nor do we display per-task copies.This PR implements a way to render per-task variants so I can see dynamic filters in nodes like
FilterExec.Solution