fix: expose Iceberg work unit feed metrics - #763
Draft
alexanderbianchi wants to merge 3 commits into
Draft
alexanderbianchi wants to merge 3 commits into
alexanderbianchi wants to merge 3 commits into
Conversation
gabotechs
reviewed
Oct 3, 2026
| partitioning, | ||
| fetch, | ||
| metrics: Default::default(), | ||
| metrics: feed.metrics(), |
Collaborator
There was a problem hiding this comment.
This code here is just the codec. There's a chance that this code is not even reached in a normal execution, and this will still miss the coordinator-collected metrics.
Instead, we should be joining both DataSource and WorkUnitFeed metrics in the metrics() method:
impl DataSource for IcebergDataSource {
...
fn metrics(&self) -> ExecutionPlanMetricsSet {
let mut all_metrics = self.feed.metrics().clone_inner();
all_metrics.extend(self.metrics.clone_inner());
ExecutionPlanMetricsSet::from(all_metrics)
}
...
}
alexanderbianchi
marked this pull request as draft
October 4, 2026 00:37
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the work unit feed as the shared metrics registry for Iceberg scans, whether execution is local or distributed.
IcebergDataSource::metrics(), which returns the feed’s shared set.This exposes feed metrics without returning a fresh registry on each call, preserving later registrations such as DataFusion’s
batches_splitcounter.Validation
cargo test -p datafusion-distributed-iceberg --features integration