-
Notifications
You must be signed in to change notification settings - Fork 98
Add BLOB support for dict of simple types #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
eaa0054
Add Dockerfile for development use
eywalker 515b4a1
Add support for dict in BLOB
eywalker 2d5ab68
Simplify character blob fetch
eywalker 14ef74d
Support packing int and float into blob
eywalker 7c4eeae
Add simple test for packing and unpacking dict to/from blob
eywalker 60b5e01
Pass through unpacking option
eywalker 37eb37f
Use proper assert in tests
eywalker f780c5d
Add nose in DevDockerfile
eywalker 351ee2b
Remove unnecessary utility funtion from blob
eywalker d465d8e
Handle iterable insert into BLOB correctly
eywalker c2faca7
Add tests for serializing lists and iterators into BLOB
eywalker 478f76a
Change testing of iterator serialization to BLOB
eywalker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| FROM eywalker/jupyter | ||
|
|
||
| MAINTAINER Edgar Y. Walker <edgar.walker@gmail.com> | ||
|
|
||
| ADD . /src | ||
| RUN pip install -e /src &&\ | ||
| pip install nose |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
objis an iterator, thennp.arraywill not exhaust it. Replace withlist(obj).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working right on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made the requested change and added tests specific to this point.