Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parallel DNS and certificate-status tests shared mutable fake-client objects and a runtime Scheme. Fake-client tracker setup assigned ResourceVersions to shared objects, and certificate reads registered kinds in the shared Scheme, producing intermittent race failures in unrelated controller tests.
Give each parallel case deep-copied objects and its own Scheme. No production behavior or test assertions change; parallelism and race detection stay enabled.
Validation: targeted race tests passed 10 repetitions; full validation/controller race suites passed with count=1 and count=3. Lead independently repeated the full suite (validation 1.956s; controller 14.084s). Original failures reproduced on pristine 4c4c48e as well as the HTTPRoute feature branch. No deployment or migration effect; rollback would restore the flaky test fixtures.