Repository navigation
feat: add better junimos compatability - #1
Merged
Merged
Conversation
PaulEndri
force-pushed
the
main
branch
4 times, most recently
from
April 7, 2026 00:11
e3460f5 to
4e74436
Compare
Author
|
Quick gif of the change working
|
Owner
|
I'l have a closer look at this before next update but it looks good so far! |
Owner
|
Thank you for the added compatability to this mod! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the Junimo Hut range on hover is hard coded, but Better Junimos allows modifying that so it was creating a jarring experience - took a look at the two code bases and it all looked straightforward enough so I built this compatibility patch.
I am a brand new SDV modder so not sure if this is the "right" way or if I'm running astray of some core programming philosophies y'all use that I'm not aware of or anything of the sorts. Or not even sure that SDV mod etiquette allows for random PRs into mods. BUT HERE I AM. My discord handle is Paul Endri so feel free to reach out if anything.
If I need to change something/anything, or I missed something, or there's literally any thing I can do: Please let me know. I'm 100% down to learn/adjust/abide/help - or if instead you want to take over this change yourself then feel free to modify my work further or close this and take inspiration from it or whatever! (I would like some credit if that happens, I do hope to get more into this community as time goes on, but I understand otherwise)