Repository navigation
Fix washed-out experience bar colors + darker mining brown - #5
Merged
Merged
Conversation
The (int, int, int, float) Color initializers bound to the all-float constructor, so every channel above 1 saturated to 255: farming / fishing / mining / luck rendered white, Combat rendered pink instead of red (its green channel was zero — the shade visible in the mod's screenshots), and only Foraging kept its intended green (two zero channels). Convert components to 0-1 floats like MasteryFillColor already does, restoring the intended colors. Co-Authored-By: Claude Code <noreply@anthropic.com>
The original tan (145,104,63) blends into the beige dialogue box the bar is drawn on. Use dark brown (101,67,33) instead, per review on dazuki#4. Co-Authored-By: Claude Code <noreply@anthropic.com>
Owner
|
Will have a more closer look at the coloring after work. Thank you for the PR! |
Owner
|
Removed the comments and changed an odd float value for the Farming skill bar which has been around for some time. Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #4 per review.
The problem
Since the original UIInfoSuite2 (2017), the
new Color(int, int, int, float)initializers bound to the all-float constructor, so every channel above 1 saturated to 255: farming / fishing / mining / luck rendered white, Combat rendered pink instead of red (its green channel was zero — the shade visible in the mod's screenshots), and only Foraging kept its intended green (two zero channels). The intended colors were in the code all along but never rendered.The fix
Convert components to explicit 0-1 floats (the same style
MasteryFillColoralready uses), restoring the intended yellow / blue / brown / red. Also darkens the mining brown from tan (145,104,63) to (101,67,33) so the bar stands out against the beige dialogue box it's drawn on, per your review on #4 — happy to tune the shade.🤖 Generated with Claude Code