Repository navigation
Conversation
`> 70` green / `>= 30` yellow was written out four times: QuotaProgressBar, QuotaTable, getStatusColor and getStatusEmoji. All four agreed, but nothing made them: an edit to one would have shown a model green in the table and yellow in the progress bar above it, with no test and no type to catch it. quotaStatusLevel() in ./utils is now the only place the boundaries appear. The two components keep their own class tables -- QuotaTable needs dark-mode text variants and the progress bar does not -- and map from the level, so what legitimately differs stays separate from what should not. Also drops an unreachable `return` left in getStatusEmoji.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
> 70green />= 30yellow / else red is the quota colour policy. It was written out four times:ProviderLimits/QuotaProgressBar.jsgetColorClassesProviderLimits/QuotaTable.jsgetColorClassesProviderLimits/utils.jsgetStatusColorProviderLimits/utils.jsgetStatusEmojiAll four agree today. Nothing makes them: an edit to one would show a model green in the table and yellow in the progress bar directly above it, with no test and no type to catch it.
No user-visible behaviour changes. Every percentage maps to exactly the colour and emoji it did before — the first two tests sweep 0–100 in 0.5 steps to say so.
The change
quotaStatusLevel()in./utilsis now the only place the numbers appear, alongside the two named boundaries.The two components keep their own class tables and map from the level. That split is deliberate:
QuotaTableneedsdark:text variants and the progress bar does not, so what legitimately differs between them stays separate from what should not. The two also hadbg,bgLightandemojiduplicated verbatim; those are now one line each per level.Net −18 lines, and an unreachable
returnleft behind ingetStatusEmojigoes with it.Evidence
tests/unit/quota-status-thresholds.test.js, 5 tests.The first three are arithmetic and would pass just as happily against four copies as against one — so the last two are the ones doing the work: they assert each component imports
quotaStatusLeveland no longer contains aremainingPercentage > 70of its own.Two-way mutation, run locally:
QuotaTable.getColorClassesrestates the thresholds inlineCaveat
This is a tidy-up, not a bug fix — the copies have not drifted yet. If you would rather not carry a source-level test that pins how a component is written, say so and I will drop the last two tests; the consolidation stands on its own.