Repository navigation
Conversation
ABACUS-PR-BOT
left a comment
There was a problem hiding this comment.
Static review found no introduced correctness defect in this extraction.
Non-blocking: Please record the actual validation commands, configuration and observed results for the extraction and new regression cases in the PR description, including checks that were not run.
Reviewed 9edc0acbb7d4 against eba09c937c73. git diff --check passed; builds and tests were not run, and CI results were not verified.
|
The CUDA failure seems unrelated to this PR as I didn't touch LCAO code. |
|
Overall: LGTM. A behavior-preserving refactor with meaningful new tests. Beyond CI, I built and ran the relax unit tests with sanitizers on two real machines, comparing against the pre-PR baseline — no regressions or hidden issues found.
|
|
The main purpose of this PR is simply to extract a sharable source file from current CG implementation, so if this doesn't preserve the previous behaviour it will become a regression bug. I would actually prefer minimum additional adjustment about this PR as I have in fact done the whole process of resolving #7970 locally; but I will carefully take a look of the advice anyways. |
|
The suggested patches are included in the new rebase & force-push. |
This is a prerequisite for moving towards #7970.