Repository navigation
Conversation
|
This upgrade also removes a CI blocker for the planned CMake cleanup. It moves CI from CMake 3.22 to 3.28 with Ubuntu 24.04 system distribution, meeting the 3.27 minimum needed for the full cleanup. |
|
I also adjusted the ELPA version in Intel Dockerfile to align with the version in the CUDA one. |
ABACUS-PR-BOT
left a comment
There was a problem hiding this comment.
The GNU base upgrade needs a matching change to the main Test job’s tool installation; details are inline. Static review covered all three Dockerfiles and affected build/CI consumers. No image builds or runtime tests were run, and CI diagnostics were unavailable.
Non-blocking: Please record exact build and smoke-check commands/results for the GNU, Intel and CUDA images in the PR description. devcontainer.yml does not build these recipes for PR events; PR jobs consume already-published images, so they do not validate the new toolchain combinations.
Non-blocking: Please update the ELPA apt note in docs/quick_start/easy_install.md:130, which currently says only Ubuntu 22.04 meets the requirements. Ubuntu 24.04 supplies ELPA 2022.11.001, above the finder’s 2021.05.001 minimum.
06a2243 to
de138be
Compare
ABACUS-PR-BOT
left a comment
There was a problem hiding this comment.
One rollout suggestion for the removed ASE safeguard is inline. Static review only; deployed-image identity, numerical results and CI status remain unverified.
|
Thanks for independently reproducing the issue and updating the images! This is consistent with our validation of the upstream fix. I’m happy to remove the Prescott override as part of this PR. |
OpenBLAS 0.3.20 in Ubuntu 22.04 can return incorrect
DSYMMresults when it selects the Cooperlake kernel, causing ASE tests to fail when the CI job runs on a runner where OpenBLAS automatically choose Cooperlake kernel. This was fixed in version 0.3.21; Ubuntu 24.04's OpenBLAS 0.3.26 package includes the fix.See also #8348 (comment). Closes #7794, closes #8348 (superseded).
Thanks @Stardust0831 for catching this!