Repository navigation
feat(xc): offload Libxc grid potentials to CUDA #8364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Stardust0831
wants to merge
5
commits into
deepmodeling:develop
Choose a base branch
from
Stardust0831:feat/libxc-cuda-grid-7-1
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+463
−64
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1224350
feat(xc): evaluate Libxc LDA and GGA potentials on CUDA
Stardust0831 93b5903
fix(xc): diagnose a stale compiler header for CUDA Libxc
Stardust0831 44efc7f
docs(xc): record the HSE force limitation in released Libxc
Stardust0831 65bedae
refactor(xc): name the Libxc device selector device_xc
Stardust0831 3332ebf
Merge develop and keep the Libxc device input test
Stardust0831 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| #ifndef LIBXC_HOST_H | ||
| #define LIBXC_HOST_H | ||
|
|
||
| #include <xc.h> | ||
|
|
||
| #if defined(ABACUS_LIBXC_CUDA) && !defined(XC_FLAGS_ON_HOST) | ||
| #error "CMake found CUDA Libxc >= 7.1.0 but xc.h lacks host/device selection. Check the compiler include path." | ||
| #endif | ||
|
|
||
| namespace XC_Functional_Libxc | ||
| { | ||
| // A CUDA-enabled Libxc defaults to device pointers. Keep host callers explicit. | ||
| inline int init_func_host(xc_func_type* func, const int id, const int spin) | ||
| { | ||
| #ifdef XC_FLAGS_ON_HOST | ||
| return xc_func_init_flags(func, id, spin, XC_FLAGS_ON_HOST); | ||
| #else | ||
| return xc_func_init(func, id, spin); | ||
| #endif | ||
| } | ||
| } // namespace XC_Functional_Libxc | ||
|
|
||
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, export an cmake dependent option
ENABLE_LIBXC_CUDA, and thenThen the
ifcondition here insource/CMakeLists.txtcan be simplyif(ENABLE_LIBXC_CUDA)