Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions haystack/components/generators/chat/mock.py
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def to_dict(self) -> dict[str, Any]:
@classmethod
def from_dict(cls, data: dict[str, Any]) -> MockChatGenerator:
"""Deserialize the component from a dictionary."""
init_params = data.get("init_parameters", {})
init_params = dict(data.get("init_parameters", {}))
responses = init_params.get("responses")
if responses is not None:
init_params["responses"] = [ChatMessage.from_dict(msg) for msg in responses]
Expand All @@ -196,7 +196,7 @@ def from_dict(cls, data: dict[str, Any]) -> MockChatGenerator:
streaming_callback = init_params.get("streaming_callback")
if streaming_callback:
init_params["streaming_callback"] = deserialize_callable(streaming_callback)
return default_from_dict(cls, data)
return default_from_dict(cls, {**data, "init_parameters": init_params})

def warm_up(self) -> None:
"""No-op warm up, provided for interface compatibility with real Chat Generators."""
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
fixes:
- |
``MockChatGenerator.from_dict()`` now preserves the supplied serialized
configuration, so the same dictionary can be loaded more than once when
using predefined responses, a response function, or a streaming callback.
9 changes: 7 additions & 2 deletions test/components/generators/chat/test_mock.py
Original file line number Diff line number Diff line change
Expand Up @@ -263,11 +263,16 @@ def test_streaming_callback_with_tool_call(self) -> None:
)
def test_serialization_roundtrip(self, generator: MockChatGenerator) -> None:

restored = MockChatGenerator.from_dict(generator.to_dict())
data = generator.to_dict()
restored = MockChatGenerator.from_dict(data)
assert isinstance(restored, MockChatGenerator)
assert data == generator.to_dict()
restored_again = MockChatGenerator.from_dict(data)
# behavior is preserved across the roundtrip
messages = [ChatMessage.from_user("hi")]
assert restored.run(messages)["replies"][0].text == generator.run(messages)["replies"][0].text
expected = generator.run(messages)["replies"][0].text
assert restored.run(messages)["replies"][0].text == expected
assert restored_again.run(messages)["replies"][0].text == expected

def test_in_pipeline(self) -> None:

Expand Down
Loading