Skip to content

Run FastFileWriter fd-close test outside pytest-forked #8015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tohtana merged 5 commits into from
May 20, 2026
Merged

Run FastFileWriter fd-close test outside pytest-forked #8015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8bd501d
test: right-size FastFileWriter pinned-buffer gate
May 19, 2026
af62a08
test: run FastFileWriter fd test sequentially
May 19, 2026
f060338
test: mark FastFileWriter fd tests sequential
May 20, 2026
71ced5e
Merge branch 'master' into tohtana/fix/aws-torch-latest-fast-file-writer
tohtana May 20, 2026
0a08db1
Merge branch 'master' into tohtana/fix/aws-torch-latest-fast-file-writer
tohtana May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/aws-torch-latest-full.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ jobs:
echo "Running sequential tests with TORCH_CUDA_ARCH_LIST=$TORCH_CUDA_ARCH_LIST on $GPU_COUNT GPUs"
cd tests
rm -rf /mnt/aio/pytest
pytest --instafail --timeout 600 --forked -m 'sequential' --basetemp=/mnt/aio/pytest unit/ \
pytest --instafail --timeout 600 -m 'sequential' --basetemp=/mnt/aio/pytest unit/ \
--ignore=unit/runtime/zero/test_nvme_checkpointing.py \
--ignore=unit/ops/aio/test_gds.py \
--ignore=unit/launcher/test_user_args.py \
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/ops/aio/test_fast_file_writer_fd_close.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ def _build_writer(file_path):
return FastFileWriter(file_path=str(file_path), config=cfg)


@pytest.mark.sequential
def test_close_releases_fd_after_unlink(tmp_path):
"""Single save + unlink must not leave a deleted-fd reference."""
target = tmp_path / "ckpt_single.pt"
Expand All @@ -87,6 +88,7 @@ def test_close_releases_fd_after_unlink(tmp_path):
f"This indicates _fini() did not os.close(self._aio_fd).")


@pytest.mark.sequential
@pytest.mark.parametrize("n_iters", [5, 20])
def test_rotation_loop_does_not_leak(tmp_path, n_iters):
"""N iterations of save+close+unlink should leave zero deleted-fds.
Expand Down
Loading