backport: dash#7312 fix CheckQueue lifetime for invalid-block logging - #41
Merged
minuszka merged 1 commit intoJul 6, 2026
Merged
Conversation
Declare txsdata before control in ConnectBlock so it outlives the CCheckQueueControl destructor. The destructor runs the parallel script checks, which hold pointers into txsdata; with control declared first it was destroyed after txsdata, so the checks could reference freed data, causing intermittent incorrect CheckQueue logging for invalid blocks. Backport of dashpay/dash#7312. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declare txsdata before control in ConnectBlock so it outlives the CCheckQueueControl destructor. The destructor runs the parallel script checks, which hold pointers into txsdata; with control declared first it was destroyed after txsdata, so the checks could reference freed data, causing intermittent incorrect CheckQueue logging for invalid blocks.
Backport of dashpay/dash#7312.