Repository navigation
test(controller): pass the init container user in the FUSE storage tests - #2277
Merged
Merged
Conversation
defilantech#2273 added an initContainerUser parameter to buildModelStorageConfig and updated the callers it knew about. defilantech#2276 added four calls in model_storage_fuse_test.go with the old signature. Each PR passed CI on its own base, but main no longer compiles the controller tests (Lint fails with "not enough arguments in call to buildModelStorageConfig"). The four calls now pass DefaultInitContainerUser, as the existing call in the same file does. Signed-off-by: Christopher Maher <chris@mahercode.io>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The four
buildModelStorageConfigcalls that #2276 added tointernal/controller/model_storage_fuse_test.gonow passDefaultInitContainerUser. That matches the existing call in the same file.Why
maindoes not compile the controller tests. The Lint job on6c7c1fe3and2fe250bbfails with:#2273 added an
initContainerUserparameter tobuildModelStorageConfigand updated the callers that existed on its base. #2276 added these four calls with the old signature. The two PRs merged without a textual conflict, and each passed CI on its own base, but together they don't compile.How
The change is test-only and touches four lines.
go vet ./...(includingGOOS=linuxforinternal/controller) is clean, andmake gatepasses: regen, drift, fmt, vet, lint and the full test suite.AI assistance: this change was AI-assisted. I reviewed the diffs and supervised the build.
Checklist
make testpasses locallymake lintpasses locallygit commit -s) per DCO