Repository navigation
fix(fmt): panic on tagged HTML template with multi-level indent - #34263
Merged
bartlomieju merged 2 commits intoMay 20, 2026
Merged
Conversation
Pin dprint-plugin-typescript 0.96.1, which contains dprint/dprint-plugin-typescript#783. That release fixes a panic in `deno fmt` when a tagged HTML/SVG template embeds content whose formatted output transitions by more than one indent level between adjacent lines (e.g. `<a><svg ...><path/></svg></a>`). Adds a spec regression test using the minimal repro from issue denoland#29963. Closes denoland#29963.
Closed
bartlomieju
marked this pull request as ready for review
May 20, 2026 13:52
littledivy
pushed a commit
to crowlKats/deno
that referenced
this pull request
Jun 10, 2026
…land#34263) `deno fmt` panics with `finish_indent was called without a corresponding start_indent` when a tagged HTML/SVG template embeds content whose formatted output transitions by more than one indent level between adjacent lines. The minimal repro from denoland#29963 is ```js console.log(html`<a><svg viewBox="0 0 16 16" width="20" height="20" fill="currentColor"> <path d="" /> </svg></a>`); ``` `markup_fmt` produces lines at indent levels 0 → 2 → 1, and `dprint-plugin-typescript`'s embedded-template path emitted only a single `StartIndent`/`FinishIndent` per transition while its end-of-template cleanup emitted one signal per remaining level, leaving the dprint IR unbalanced. The fix is in `dprint-plugin-typescript` (dprint/dprint-plugin-typescript#783) and is consumed here by bumping the pin to `=0.96.1`. A spec regression test in `tests/specs/fmt/embedded_html_multi_indent` covers the case using the exact input from the issue and asserts the expected formatted output. Closes denoland#29963 Closes denoland#33623 Closes denoland#31820 Closes denoland#30276 Closes denoland#30980
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deno fmtpanics withfinish_indent was called without a corresponding start_indentwhen a tagged HTML/SVG template embeds content whoseformatted output transitions by more than one indent level between
adjacent lines. The minimal repro from #29963 is
markup_fmtproduces lines at indent levels 0 → 2 → 1, anddprint-plugin-typescript's embedded-template path emitted only asingle
StartIndent/FinishIndentper transition while itsend-of-template cleanup emitted one signal per remaining level, leaving
the dprint IR unbalanced.
The fix is in
dprint-plugin-typescript(dprint/dprint-plugin-typescript#783) and is consumed here by bumping
the pin to
=0.96.1. A spec regression test intests/specs/fmt/embedded_html_multi_indentcovers the case using theexact input from the issue and asserts the expected formatted output.
Marking as draft until
dprint-plugin-typescript 0.96.1is published;once it lands on crates.io this is ready to merge as-is.
Closes #29963
Closes #33623
Closes #31820
Closes #30276
Closes #30980