Repository navigation
feat(ext/node): make Network.* CDP events fire under plain --inspect - #34270
Merged
bartlomieju merged 1 commit intoMay 20, 2026
Merged
bartlomieju merged 1 commit into
bartlomieju merged 1 commit into
Conversation
Hoists the bridge install out of the node:inspector polyfill so ext/fetch (and the other Network.* emitters) work under plain --inspect without requiring `import "node:inspector"` in user code. Also wires WebSocket frame events and instruments Deno.upgradeWebSocket so server-accepted sockets show up too.
littledivy
pushed a commit
to crowlKats/deno
that referenced
this pull request
Jun 10, 2026
…enoland#34270) Network.* CDP events for fetch and WebSocket only fired when user code imported node:inspector — the bridge that ext/fetch and ext/websocket look up on internals.__inspectorNetwork was installed inside that polyfill's module body. Attaching Chrome DevTools to a script that didn't import node:inspector showed nothing in the Network tab. Moves the bridge install into a small always-loaded script that runs at runtime startup via the node:process bootstrap. Also wires the missing WebSocket frame events (frameSent / frameReceived / frameError) and instruments Deno.upgradeWebSocket so server-side sockets accepted via Deno.serve show up alongside their clients in the inspector.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Network.* CDP events for fetch and WebSocket only fired when user code
imported node:inspector — the bridge that ext/fetch and ext/websocket
look up on internals.__inspectorNetwork was installed inside that
polyfill's module body. Attaching Chrome DevTools to a script that
didn't import node:inspector showed nothing in the Network tab.
Moves the bridge install into a small always-loaded script that runs at
runtime startup via the node:process bootstrap. Also wires the missing
WebSocket frame events (frameSent / frameReceived / frameError) and
instruments Deno.upgradeWebSocket so server-side sockets accepted via
Deno.serve show up alongside their clients in the inspector.