Repository navigation
fix(core): disable include_icu_data feature - #34279
Merged
Merged
Conversation
nathanwhit
enabled auto-merge (squash)
May 20, 2026 23:50
littledivy
pushed a commit
to crowlKats/deno
that referenced
this pull request
Jun 10, 2026
This change denoland/rusty_v8@12d7ef1#diff-b2b1f3ec619c03c5bba2f171beab1301d960e1dcac6a17a99ce02326ce9c49b4R83 made it so icu data is bundled in with v8 unconditionally, so we don't need to include the copy from deno_core anymore. Resolves a roughly 11MB regression in binary size with the v8 upgrade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change denoland/rusty_v8@12d7ef1#diff-b2b1f3ec619c03c5bba2f171beab1301d960e1dcac6a17a99ce02326ce9c49b4R83
made it so icu data is bundled in with v8 unconditionally, so we don't need to include the copy from deno_core anymore.
Resolves a roughly 11MB regression in binary size with the v8 upgrade.