Skip to content

fix(core): disable include_icu_data feature - #34279

Merged
nathanwhit merged 1 commit into
denoland:mainfrom
nathanwhit:rm-icu-feature
May 21, 2026
Merged

nathanwhit merged 1 commit into
denoland:mainfrom
nathanwhit:rm-icu-feature

Conversation

@nathanwhit

Copy link
Copy Markdown
Member

This change denoland/rusty_v8@12d7ef1#diff-b2b1f3ec619c03c5bba2f171beab1301d960e1dcac6a17a99ce02326ce9c49b4R83

made it so icu data is bundled in with v8 unconditionally, so we don't need to include the copy from deno_core anymore.

Resolves a roughly 11MB regression in binary size with the v8 upgrade.

@nathanwhit
nathanwhit enabled auto-merge (squash) May 20, 2026 23:50
@nathanwhit
nathanwhit merged commit 8266125 into denoland:main May 21, 2026
136 checks passed
@nathanwhit
nathanwhit deleted the rm-icu-feature branch May 21, 2026 00:26
littledivy pushed a commit to crowlKats/deno that referenced this pull request Jun 10, 2026
This change
denoland/rusty_v8@12d7ef1#diff-b2b1f3ec619c03c5bba2f171beab1301d960e1dcac6a17a99ce02326ce9c49b4R83

made it so icu data is bundled in with v8 unconditionally, so we don't
need to include the copy from deno_core anymore.

Resolves a roughly 11MB regression in binary size with the v8 upgrade.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant