Repository navigation
fix(io): cancel pending readable stream reads - #34986
Merged
Merged
Conversation
Co-Authored-By: Divy Srivastava <me@littledivy.com>
littledivy
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canceling a resource-backed readable stream now asks the backing resource to cancel pending read ops before deciding whether to close the rid. This lets Deno.stdin.readable cancel an outstanding terminal read without closing stdin, so the process can exit normally.
FileResource now rotates its one-shot cancel handle after canceling reads so stdin remains usable for later reads.
Tests:
Closes #34985
Closes denoland/divybot#517