Skip to content

fix(http): preserve trust proxy environment setting - #36073

Merged
nathanwhit merged 1 commit into
denoland:mainfrom
nathanwhit:fix/http-proxy-env-config
Jul 16, 2026
Merged

nathanwhit merged 1 commit into
denoland:mainfrom
nathanwhit:fix/http-proxy-env-config

Conversation

@nathanwhit

Copy link
Copy Markdown
Member

Summary

  • keep DENO_TRUST_PROXY_HEADERS in the process environment after caching its value
  • extend the existing serve spec to cover the setting after the first request

Details

trust_proxy_headers() initializes its cached configuration when the first request is handled. That initialization also removed the environment variable, so reading the configuration had an unexpected process-wide side effect after startup.

This keeps the existing cached behavior while leaving the process environment unchanged.

Validation

  • ./tools/format.js
  • cargo check -p deno_http
  • cargo build --bin deno
  • cargo test -p specs_tests --test specs -- trust_proxy_headers

@nathanwhit
nathanwhit marked this pull request as ready for review July 15, 2026 22:47

@bartlomieju bartlomieju left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Removing the remove_var eliminates an unsafe process-wide env mutation and the surprising side effect of hiding the variable. One thing worth a line in the description: the var now stays in the environment, so it's visible to user code via Deno.env.get and inherited by spawned subprocesses (previously it wasn't). Assuming that's intended (it pairs well with #36074), this is good.

@nathanwhit
nathanwhit merged commit a253d1a into denoland:main Jul 16, 2026
172 checks passed
@nathanwhit
nathanwhit deleted the fix/http-proxy-env-config branch July 16, 2026 18:28
bartlomieju pushed a commit that referenced this pull request Jul 23, 2026
## Summary

- keep `DENO_TRUST_PROXY_HEADERS` in the process environment after
caching its value
- extend the existing serve spec to cover the setting after the first
request

## Details

`trust_proxy_headers()` initializes its cached configuration when the
first request is handled. That initialization also removed the
environment variable, so reading the configuration had an unexpected
process-wide side effect after startup.

This keeps the existing cached behavior while leaving the process
environment unchanged.

## Validation

- `./tools/format.js`
- `cargo check -p deno_http`
- `cargo build --bin deno`
- `cargo test -p specs_tests --test specs -- trust_proxy_headers`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants