Repository navigation
fix(http): preserve trust proxy environment setting - #36073
Merged
Merged
Conversation
nathanwhit
marked this pull request as ready for review
July 15, 2026 22:47
bartlomieju
approved these changes
Jul 16, 2026
bartlomieju
left a comment
Member
There was a problem hiding this comment.
LGTM. Removing the remove_var eliminates an unsafe process-wide env mutation and the surprising side effect of hiding the variable. One thing worth a line in the description: the var now stays in the environment, so it's visible to user code via Deno.env.get and inherited by spawned subprocesses (previously it wasn't). Assuming that's intended (it pairs well with #36074), this is good.
bartlomieju
pushed a commit
that referenced
this pull request
Jul 23, 2026
## Summary - keep `DENO_TRUST_PROXY_HEADERS` in the process environment after caching its value - extend the existing serve spec to cover the setting after the first request ## Details `trust_proxy_headers()` initializes its cached configuration when the first request is handled. That initialization also removed the environment variable, so reading the configuration had an unexpected process-wide side effect after startup. This keeps the existing cached behavior while leaving the process environment unchanged. ## Validation - `./tools/format.js` - `cargo check -p deno_http` - `cargo build --bin deno` - `cargo test -p specs_tests --test specs -- trust_proxy_headers`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DENO_TRUST_PROXY_HEADERSin the process environment after caching its valueDetails
trust_proxy_headers()initializes its cached configuration when the first request is handled. That initialization also removed the environment variable, so reading the configuration had an unexpected process-wide side effect after startup.This keeps the existing cached behavior while leaving the process environment unchanged.
Validation
./tools/format.jscargo check -p deno_httpcargo build --bin denocargo test -p specs_tests --test specs -- trust_proxy_headers