Repository navigation
fix(ext/napi): check napi_create_dataview bounds for overflow - #36962
Merged
Merged
Conversation
bartlomieju
enabled auto-merge (squash)
October 6, 2026 09:05
bartlomieju
added a commit
that referenced
this pull request
Oct 21, 2026
(cherry picked from commit ead2af9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
napi_create_dataviewcheckedbyte_length + byte_offsetagainst the buffersize without guarding the addition. Addon-controlled values could overflow it:
debug builds panicked across the
extern "C"boundary, and release buildswrapped around, so the bounds check passed and V8 was handed an out-of-range
DataView. The sum is now computed with
checked_add, and an overflow istreated as out of range, throwing the same RangeError as any other bad offset.
Follow-up to #36942.