Let rust rls linter find the default rust toolchain automatically#2432
Merged
Conversation
w0rp
approved these changes
Apr 11, 2019
Member
|
Cheers! 🍻 |
weirane
added a commit
to weirane/dotfiles
that referenced
this pull request
Apr 18, 2019
after dense-analysis/ale/pull/2432, the toolchain can be detected automatically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch comes from this comment.
As
rlsandclippyare not always available for the latest nightly rust build, nightly rust users typically needs to specify another version of nightly rust in order to getrlsworking. The version string looks somewhat likenightly-2019-03-05instead of justnightly. Therefore, the default value ofg:ale_rust_rls_toolchainnightlyusually just doesn't work and the documentation also did not point out the use of customizable toolchain names. In fact,rlsactually allows users to omit the toolchain name so that it will automatically find the default toolchain set byrustup, and the linter actually supports this behavior but it was not reflected in the documentation. Therefore, setting the default value as''is more suitable for most cases. In addition, stable rust users also won't need to change this variable by hand, and rls linter can work out-of-the-box.I have read
:help ale-dev. This patch does not seem to need additional tests.