Allow headers to participate in the project.#2919
Closed
bogado wants to merge 1 commit into
Closed
Conversation
Member
|
I've pushed a commit now which has this with tests for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think there's a good reason to disable unconditionally the use of the compile database when editing headers. It's an unexpected behavior and at least on my use case here it seems to break the linting on headers.
There are no tests, I could not find the tests that are testing that, and I can understand if that is denied on this grounds. Unfortunately I have little time to dig into how to run and add tests, sorry.