Update ale#python#FindProjectRootIni with poetry.lock and pyproject.toml#3398
Conversation
|
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
|
@hsanson @lifecrisis would anyone be willing to help get this very minor convenience update for Python developers in? |
|
On Fri, 2020-11-13 at 02:56 -0800, Emil Lynegaard wrote:
@hsanson @lifecrisis would anyone be willing to help get this very minor convenience update for Python developers in?
Not sure why you would pick me, as I am not a maintainer. :)
I'll give my input though...
Based on a perfunctory review of the mentioned PEP, the "pyproject.toml"
file looks like it's worth including.
The "poetry" project looks popular enough that many users would be
helped by including this one as well.
Good luck!
…--
Jason
|
|
@lifecrisis - oh that is my bad, I guess I was not very thorough in my search for maintainers. Thank you very much for the input nonetheless! |
|
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
|
Any support for this? I just ran into this issue. |
hsanson
left a comment
There was a problem hiding this comment.
Looks good and useful. Thanks.
Adds 'poetry.lock' used by poetry and 'pyproject.toml' from PEP 518 as filenames indicating a Python project's root.
This coincides with the much larger PR with poetry auto detection support #2963, but could hopefully be merged with less concern, and will have immediate benefit.
I have several projects based on poetry for which all configuration is done through
pyproject.toml, and ALE is currently unable to correctly determine the project roots due to the absence of all of the currently implemented configuration files.