Skip to content

Update ale#python#FindProjectRootIni with poetry.lock and pyproject.toml#3398

Merged
hsanson merged 1 commit into
dense-analysis:masterfrom
ecly:update-python-find-root
Jan 13, 2021
Merged

Update ale#python#FindProjectRootIni with poetry.lock and pyproject.toml#3398
hsanson merged 1 commit into
dense-analysis:masterfrom
ecly:update-python-find-root

Conversation

@ecly
Copy link
Copy Markdown
Contributor

@ecly ecly commented Oct 15, 2020

Adds 'poetry.lock' used by poetry and 'pyproject.toml' from PEP 518 as filenames indicating a Python project's root.

This coincides with the much larger PR with poetry auto detection support #2963, but could hopefully be merged with less concern, and will have immediate benefit.

I have several projects based on poetry for which all configuration is done through pyproject.toml, and ALE is currently unable to correctly determine the project roots due to the absence of all of the currently implemented configuration files.

@stale
Copy link
Copy Markdown

stale Bot commented Nov 12, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale Bot added the stale PRs/Issues no longer valid label Nov 12, 2020
@ecly
Copy link
Copy Markdown
Contributor Author

ecly commented Nov 13, 2020

@hsanson @lifecrisis would anyone be willing to help get this very minor convenience update for Python developers in?

@lifecrisis
Copy link
Copy Markdown
Contributor

lifecrisis commented Nov 13, 2020 via email

@stale stale Bot removed the stale PRs/Issues no longer valid label Nov 13, 2020
@ecly
Copy link
Copy Markdown
Contributor Author

ecly commented Nov 13, 2020

@lifecrisis - oh that is my bad, I guess I was not very thorough in my search for maintainers. Thank you very much for the input nonetheless!

@stale
Copy link
Copy Markdown

stale Bot commented Dec 11, 2020

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale Bot added the stale PRs/Issues no longer valid label Dec 11, 2020
@stale stale Bot closed this Dec 18, 2020
@HoughIO
Copy link
Copy Markdown

HoughIO commented Jan 13, 2021

Any support for this? I just ran into this issue.

@hsanson hsanson reopened this Jan 13, 2021
@stale stale Bot removed the stale PRs/Issues no longer valid label Jan 13, 2021
Copy link
Copy Markdown
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and useful. Thanks.

@hsanson hsanson merged commit aabca5b into dense-analysis:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants