Skip to content

codefix: Fix LSP MenuCallback invocation (E119, not enough args)#3482

Merged
hsanson merged 1 commit into
dense-analysis:masterfrom
liskin:lsp-popup-menu-fix
Jan 13, 2021
Merged

codefix: Fix LSP MenuCallback invocation (E119, not enough args)#3482
hsanson merged 1 commit into
dense-analysis:masterfrom
liskin:lsp-popup-menu-fix

Conversation

@liskin
Copy link
Copy Markdown
Contributor

@liskin liskin commented Dec 5, 2020

Where are the tests? Have you added tests? Have you updated the tests? Read the
comment above and the documentation referenced in it first. Write tests!
Seriously, read :help ale-dev and write tests.

Can the right-click menu be tested somehow? Dunno. :-(

@tmc
Copy link
Copy Markdown
Contributor

tmc commented Dec 12, 2020

Looking forward to this merging!

@stale
Copy link
Copy Markdown

stale Bot commented Jan 9, 2021

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale Bot added the stale PRs/Issues no longer valid label Jan 9, 2021
@liskin
Copy link
Copy Markdown
Contributor Author

liskin commented Jan 9, 2021

@w0rp @hsanson Any hints how to add a test for this?

@stale stale Bot removed the stale PRs/Issues no longer valid label Jan 9, 2021
@hsanson
Copy link
Copy Markdown
Contributor

hsanson commented Jan 13, 2021

@liskin I have never encounter this error. Can you provide me instructions on how to trigger it so I can test the fix?

@liskin
Copy link
Copy Markdown
Contributor Author

liskin commented Jan 13, 2021

@hsanson

  1. setup right click to open popup (probably default in gvim, needs set nocompatible mouse=a mousemodel=popup_setpos in console vim)
  2. open file where some LSP is active (I tested with python and pyls)
  3. right click
  4. boom, there's a E119 error

Copy link
Copy Markdown
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed this PR fixes a bug in the call.

@hsanson hsanson merged commit 7b187af into dense-analysis:master Jan 13, 2021
@liskin liskin deleted the lsp-popup-menu-fix branch January 13, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants