Add support for Vala-Lint#3519
Merged
hsanson merged 20 commits intoJan 22, 2021
Merged
Conversation
hsanson
requested changes
Jan 13, 2021
Contributor
Author
|
@hsanson Thanks for your review. I applied suggested changes. Please take a look and let me know what you think. Thanks! |
hsanson
previously approved these changes
Jan 15, 2021
Contributor
hsanson
left a comment
There was a problem hiding this comment.
This is good to merge. Waiting for Travis-CI to get fixed so all checks pass before merging.
Contributor
Author
|
Great! I'm holding my 🍺️ until Travis-CI gets fixed. |
Contributor
|
ALE migrated from Travis to Github Actions (see #3548) so it is necessary to rebase this PR from latest master branch to trigger the required checks. |
…f config filename value
Contributor
Author
|
Done. I also updated the linter name to snake case as the test indicated. |
Contributor
Author
|
Cheers! 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I added support for Vala-Lint. I've been using it myself, and it's working just fine.
Let me know if you have any questions. Thanks!