Skip to content

Add support for Vala-Lint#3519

Merged
hsanson merged 20 commits into
dense-analysis:masterfrom
atsuya:feature/support-vala-lint
Jan 22, 2021
Merged

Add support for Vala-Lint#3519
hsanson merged 20 commits into
dense-analysis:masterfrom
atsuya:feature/support-vala-lint

Conversation

@atsuya
Copy link
Copy Markdown
Contributor

@atsuya atsuya commented Jan 5, 2021

Hi,

I added support for Vala-Lint. I've been using it myself, and it's working just fine.

Let me know if you have any questions. Thanks!

@atsuya atsuya closed this Jan 5, 2021
@atsuya atsuya reopened this Jan 5, 2021
Comment thread ale_linters/vala/vala_lint.vim Outdated
Comment thread ale_linters/vala/vala_lint.vim Outdated
Comment thread ale_linters/vala/vala_lint.vim Outdated
@atsuya
Copy link
Copy Markdown
Contributor Author

atsuya commented Jan 14, 2021

@hsanson Thanks for your review. I applied suggested changes. Please take a look and let me know what you think. Thanks!

@atsuya atsuya requested a review from hsanson January 15, 2021 00:10
hsanson
hsanson previously approved these changes Jan 15, 2021
Copy link
Copy Markdown
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to merge. Waiting for Travis-CI to get fixed so all checks pass before merging.

@atsuya
Copy link
Copy Markdown
Contributor Author

atsuya commented Jan 15, 2021

Great! I'm holding my 🍺️ until Travis-CI gets fixed.

@hsanson
Copy link
Copy Markdown
Contributor

hsanson commented Jan 22, 2021

ALE migrated from Travis to Github Actions (see #3548) so it is necessary to rebase this PR from latest master branch to trigger the required checks.

# Add dense-analysis as remote upstream on your local fork. Not 
# needed if already added.
git remote add upstream https://github.com/dense-analysis/ale.git

# Sync your local master with upstream master
git checkout master
git fetch upstream master
git merge upstream/master

# Rebase the PR branch with master
git checkout my-branch-name
git rebase master   # Fix any conflicts you may have

# Force push the updated PR branch to origin to trigger the checks
git push -f origin my-branch-name

@atsuya
Copy link
Copy Markdown
Contributor Author

atsuya commented Jan 22, 2021

Done. I also updated the linter name to snake case as the test indicated.

@atsuya atsuya requested a review from hsanson January 22, 2021 15:23
Copy link
Copy Markdown
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, thanks.

@hsanson hsanson merged commit 9a1e91e into dense-analysis:master Jan 22, 2021
@atsuya
Copy link
Copy Markdown
Contributor Author

atsuya commented Jan 23, 2021

Cheers! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants