Fix 3537 - remove -T argument from ruby linter#3538
Merged
hsanson merged 1 commit intoFeb 23, 2021
Conversation
hsanson
force-pushed
the
3537-remove-ruby-taint-checks
branch
from
2c4691f to
56b7eb3
Compare
hsanson
force-pushed
the
3537-remove-ruby-taint-checks
branch
from
56b7eb3 to
4c78cae
Compare
parkr
approved these changes
Feb 22, 2021
|
After the upgrade to Ruby 3 (out since Dec 2020, nearly 2 months), this is now failing: |
|
@hsanson Is anyone able to approve this PR from your team of maintainers? |
Member
|
Thanks for merging this. This is good to have. |
ahayworth
added a commit
to ahayworth/ale
that referenced
this pull request
Oct 21, 2021
The `-T` option (for "taint checking") was deprecated in ruby 2.7 and removed entirely in ruby 3.0. This causes the linter to fail entirely for users of ruby 3.0. This was reported in dense-analysis#3537, and then fixed in dense-analysis#3538 - but it seems as though in 9fe7b1f, it was accidentally and entirely undone. This commit is essentially identical to dense-analysis#3538, aside from a path change for the tests.
hsanson
pushed a commit
that referenced
this pull request
Oct 22, 2021
The `-T` option (for "taint checking") was deprecated in ruby 2.7 and removed entirely in ruby 3.0. This causes the linter to fail entirely for users of ruby 3.0. This was reported in #3537, and then fixed in #3538 - but it seems as though in 9fe7b1f, it was accidentally and entirely undone. This commit is essentially identical to #3538, aside from a path change for the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3537