Skip to content

fix(ale_linters: python: ruff): add --stdin-filename if version >= 0.0.69#4414

Merged
hsanson merged 1 commit into
dense-analysis:masterfrom
actionless:ruff-stdin-filename
Jan 27, 2023
Merged

fix(ale_linters: python: ruff): add --stdin-filename if version >= 0.0.69#4414
hsanson merged 1 commit into
dense-analysis:masterfrom
actionless:ruff-stdin-filename

Conversation

@actionless
Copy link
Copy Markdown
Contributor

@actionless actionless commented Jan 7, 2023

Where are the tests? Have you added tests? Have you updated the tests? Read the
comment above and the documentation referenced in it first. Write tests!

Seriously, read :help ale-dev and write tests.

yes

@actionless actionless changed the title fix(ale_linters: python: ruff): add --stdin-filename if version > 0.0.69 fix(ale_linters: python: ruff): add --stdin-filename if version >= 0.0.69 Jan 7, 2023
@actionless actionless force-pushed the ruff-stdin-filename branch 3 times, most recently from 9528132 to 8f617a0 Compare January 7, 2023 01:03
@actionless actionless force-pushed the ruff-stdin-filename branch from 8f617a0 to bdd3f8c Compare January 7, 2023 01:10
@yining
Copy link
Copy Markdown
Contributor

yining commented Jan 7, 2023

Good catch, thanks for the fix. I forgot to add '--stdin-filename' to linter after adding that to fixer.

Copy link
Copy Markdown
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants