Skip to content

What's the reason for peerDependencies? #139

Closed

Description

@Timer

Hi! What's the reason for having preact and react listed as peerDependencies in the * range?

This creates some unnecessary noise for users installing the package in their projects.

Would you accept a pull request removing these?

Activity

  1. Timer commented on Feb 17, 2019

    @Timer
    ContributorAuthor

    Actually, I just realized that unistore has integrations and requires the peer dependencies for newer features (e.g. Yarn PnP).

    Could we use the new RFC and make these optional?

    yarnpkg/rfcs#105

    {
      "peerDependencies": {
        "preact": "optional:*",
        "react": "optional:*"
      }
    }
  2. NathanielHill commented on Feb 22, 2019

    @NathanielHill

    Yes please. 🙏

  3. Timer commented on Mar 7, 2019

    @Timer
    ContributorAuthor

    Looks like I didn't catch the change to the RFC. Please see PR: #142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions