Bug description
As seen in this PR, the build-bot only found 4 PRs:
There are actually 6 icons that should be included. These are not found by the bot because I coded it like this:
- Query the API for the PRs
- Get all the PRs UP UNTIL the PR with a name matching "Release v"
The two missing PRs (bottom two here which were added manually by me), when searched on GitHub, shows up AFTER the "Release v" PR. I think GitHub sorted them by open dates, not merged date.
Possible fixes or solutions
Find a way to query the APIs based on merge dates rather than opened dates. If not, probably goes past the end PR a little bit.
Additional information
Not critical but we should have it.
Bug description
As seen in this PR, the
build-botonly found 4 PRs:There are actually 6 icons that should be included. These are not found by the bot because I coded it like this:
The two missing PRs (bottom two here which were added manually by me), when searched on GitHub, shows up AFTER the "Release v" PR. I think GitHub sorted them by open dates, not merged date.
Possible fixes or solutions
Find a way to query the APIs based on merge dates rather than opened dates. If not, probably goes past the end PR a little bit.
Additional information
Not critical but we should have it.