Skip to content

new icon: almalinux (original, original-wordmark, plain, plain-wordmark) - #1889

Merged
canaleal merged 5 commits into
devicons:developfrom
canaleal:new-icon-almalinux
Jul 9, 2024
Merged

new icon: almalinux (original, original-wordmark, plain, plain-wordmark)#1889
canaleal merged 5 commits into
devicons:developfrom
canaleal:new-icon-almalinux

Conversation

@canaleal

@canaleal canaleal commented Oct 7, 2023

Copy link
Copy Markdown
Member

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1826

Link to prove your SVG is correct and up-to-date.

Main Website: https://almalinux.org/
Github: https://github.com/AlmaLinux/
Wiki: https://en.wikipedia.org/wiki/AlmaLinux

Almalinux has a whole heap of colors in the original logo; I went with #ffffff as the main icon color given how it's the most prominent color. I also choose #000000 for the plain icons.

@Snailedlt Snailedlt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paths need to be unified for the plain and plain-wordmark versions. Other than that this PR looks excellent!

Snailedlt
Snailedlt previously approved these changes Oct 21, 2023

@Snailedlt Snailedlt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for another great contribution! 🚀

@Snailedlt
Snailedlt requested review from a team, ConX and lunatic-fox and removed request for a team October 21, 2023 23:07
@Snailedlt Snailedlt added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 21, 2023
@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Oct 30, 2023

@lunatic-fox lunatic-fox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there!
Seems that the files get a little bit smaller when ungroup and unify some paths, so here are them already modified.

original

original-wordmark

PS: I can't commit myself on this pull request right now.

@lunatic-fox lunatic-fox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 💯
Thank you for this contribution! 🚀

@lunatic-fox
lunatic-fox requested a review from Snailedlt November 9, 2023 22:55
@canaleal
canaleal requested a review from weh June 3, 2024 03:30

@weh weh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to change, Thank you 👍

@github-actions

github-actions Bot commented Jul 9, 2024

Copy link
Copy Markdown
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal
canaleal merged commit 852ed49 into devicons:develop Jul 9, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
new icon: almalinux (original, original-wordmark, plain, plain-wordmark)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants