Refactor: configmanager Package's Readability Enhancement#1246
Merged
Conversation
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
daniel-hutao
force-pushed
the
test-ht
branch
from
56cd984 to
17abf65
Compare
steinliber
reviewed
Nov 22, 2022
steinliber
left a comment
steinliber
left a comment
There was a problem hiding this comment.
we can put LoadCofig in pluginengine, Then all main logic func can be starts with uppercase. I think export func which only used in module is not a good choice
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
Member
Author
I'll take a deeper think at this afternoon. |
IronCore864
approved these changes
Nov 22, 2022
steinliber
approved these changes
Nov 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Hu tao.hu@merico.dev
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
configmanager package's readability enhancement
Related Issues
N/A
New Behavior (screenshots if needed)
N/A