Skip to content

Microsoft Connector: Update group scope to groupMember.read.all - #4046

Open
ap0phi5 wants to merge 2 commits into
dexidp:masterfrom
ap0phi5:master
Open

ap0phi5 wants to merge 2 commits into
dexidp:masterfrom
ap0phi5:master

Conversation

@ap0phi5

@ap0phi5 ap0phi5 commented Mar 13, 2025

Copy link
Copy Markdown

Overview

This is a small change to reduce the default permission scope for a Microsoft connector from the overly-permissive directory.read.all down to groupMember.read.all.

What this PR does / why we need it

Closes #3989

@ap0phi5 ap0phi5 changed the title Update group scope to groupMember.read.all Microsoft Connector: Update group scope to groupMember.read.all Mar 13, 2025
Signed-off-by: Tom Bamford <5719506+ap0phi5@users.noreply.github.com>
@ap0phi5
ap0phi5 marked this pull request as ready for review March 13, 2025 14:29
@ap0phi5

ap0phi5 commented Mar 15, 2025

Copy link
Copy Markdown
Author

Anyone able to allow this to run the CI tests?

@ap0phi5

ap0phi5 commented Mar 24, 2025

Copy link
Copy Markdown
Author

@nabokihms If it is within your purview, could you let the tests run on this please?
The details look a bit old but I'm assuming this tenant is still available?
https://github.com/dexidp/dex/blob/master/connector/microsoft/microsoft_test.go#L20-L23

@ap0phi5

ap0phi5 commented Jun 24, 2025

Copy link
Copy Markdown
Author

Bump. Is there anything more I can do to help this PR be considered?

@cardoe cardoe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading through what is needed @ap0phi5 is correct that the lesser permission is good enough.

@sagikazarmark

Copy link
Copy Markdown
Member

Looks like CI is stuck. In any case, I wonder if it would make sense to make this configurable. @cardoe is telling me that it requires reapproval which may be a problem for users.

We could leave the default the old value for a while and after a grace period change it to the new one.

@sagikazarmark

Copy link
Copy Markdown
Member

Actually, I've been thinking about something like Kubernetes' feature flag for a while now. This would be a prime candidate.

@Geethree

Copy link
Copy Markdown

It would be really great to get this merged!

@lukeplausin

Copy link
Copy Markdown

It's been quite a long time now since the issue was raised and no action taken.

Personally I think it's very little effort for an Entra SysAdmin to approve a permissions change request for apps that are reducing their permissions from Directory.Read.All to GroupMember.Read.All, and something most admins would be happy to do.

@sagikazarmark would you be happy to approve the change without configuration, on the basis that it's a security improvement that most Entra SysAdmins would welcome?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Microsoft Connector: Overly-permissive scope

5 participants