Repository navigation
chore(build): bump base image and security improvement - #282
Merged
Merged
Conversation
📊 Build Bundle StatsThe latest build generated the following assets: |
yhabib
force-pushed
the
chore/bump-base-image-and-node
branch
3 times, most recently
from
March 3, 2026 12:56
678390f to
72233a6
Compare
yhabib
marked this pull request as ready for review
March 3, 2026 13:02
0xFFrancesco
reviewed
Mar 3, 2026
0xFFrancesco
reviewed
Mar 4, 2026
0xFFrancesco
approved these changes
Mar 4, 2026
0xFFrancesco
left a comment
There was a problem hiding this comment.
As discussed, unless there is an immediate need for this change to be merged, I think we should before update the NNS-dapp and keep the node versions in sync 😄
yhabib
force-pushed
the
chore/bump-base-image-and-node
branch
from
March 4, 2026 13:15
72233a6 to
0b3b6cc
Compare
Collaborator
Author
nns-dapp PR: dfinity/nns-dapp#7764 |
…:16]: bump node version
…:16]: bump base image
…:16]: add minimumReleaseAge
…:07]: add missing references
…ckwards compatibility
yhabib
force-pushed
the
chore/bump-base-image-and-node
branch
from
March 5, 2026 09:18
8b20b8d to
6e20004
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The new base image uses the latest version of Node. This enables a security feature called
minimumReleaseAge, which prevents the package from installing packages that are not older than 7 days.Note 1: Some dependencies still do not support eslint@10, so overrides have been added to package.json.
Note 2: Relevant topic for enabling whitelists for the new security flag to hotfix dependencies.
Changes
.nvmrcandpackage.jsonengines.0.0.8to0.0.9.min-release-age=7to.npmrcto avoid installing packages published less than 7 days ago.package-lock.json.