Repository navigation
Conversation
|
✅ No security or compliance issues detected. Reviewed everything up to ce67bb5. Security OverviewDetected Code Changes
|
📊 Build Bundle StatsThe latest build generated the following assets: |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new active-tab labels have insufficient contrast in dark mode.
1 open finding
What changed in this PR
Replaces the mobile bottom bar with a floating glass capsule, building on #494’s safe-area support.
Changes:
- Adds short tab labels while preserving full accessible names.
- Introduces translucent styling and a fade behind the capsule.
- Reserves content space using shared navigation dimensions.
| File | Description |
|---|---|
src/governance-app-frontend/src/i18n/en/common.json |
Adds short tab translations. |
src/governance-app-frontend/src/common/components/navigation/NavigationItems.tsx |
Defines tab-label keys. |
src/governance-app-frontend/src/common/components/navigation/BottomNav.tsx |
Implements the floating capsule and labels. |
src/governance-app-frontend/src/common/components/MainLayout.tsx |
Positions navigation and reserves content clearance. |
src/governance-app-frontend/src/app/styles/main.css |
Defines navigation height, gap, and clearance variables. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
yhabib
changed the base branch from
fix/bottom-nav-safe-area
to
ux/proposal-jump-to-vote
October 15, 2026 07:44
Add a "Vote" badge link to the header badge row. It scrolls smoothly to the voting card and moves the focus to it. Below the lg breakpoint, show a sticky "Vote" button above the bottom navigation. Hide it when the voting card is in view or above it. Show both only when the user can vote on the proposal.
…card Replace the jump link and the sticky jump button with a sticky footer. The Yes/No buttons float at the bottom of the page while the voting card is below it, and dock under the card when the user reaches it. Show the footer only when the user can vote. Keep the "Vote cast" footer inside the card.
…cked footer Recreate the observer when the size of main changes, so the docked state follows the bottom padding at each breakpoint. Draw the footer outline with inset shadows. A transparent top border left a 1px notch in the side borders where the footer joins the card.
yhabib
force-pushed
the
ux/proposal-jump-to-vote
branch
from
October 15, 2026 09:42
43d7023 to
af3e4b1
Compare
The mobile bottom nav is now a floating capsule, like the iOS 26 tab bar. The content scrolls behind it to the screen edge. Each tab shows a short label under its icon.
yhabib
force-pushed
the
ux/glass-bottom-nav
branch
from
October 15, 2026 09:43
200dd2c to
33ef912
Compare
… nav A neutral lens now marks the active tab. It slides to the next tab and stretches while it moves. The active icon is filled. The capsule glass is clearer, and the content behind and below it is blurred, not faded.
…e effect The content below the capsule now fades into the page, with a light 2px blur. The strong 6px blur made the text under the capsule look like a smudge.
Copilot
AI
dismissed their stale review, a newer Copilot review was requested
October 16, 2026 23:42
# Conflicts: # src/governance-app-frontend/src/common/components/navigation/BottomNav.tsx
Copilot
AI
dismissed their stale review, a newer Copilot review was requested
November 5, 2026 10:43
Copilot
AI
dismissed their stale review, a newer Copilot review was requested
November 5, 2026 10:55
Copilot
AI
dismissed their stale review, a newer Copilot review was requested
November 5, 2026 11:17
yhabib
force-pushed
the
ux/proposal-jump-to-vote
branch
from
November 5, 2026 15:39
de30fdc to
300126e
Compare
# Conflicts: # src/governance-app-frontend/src/common/components/navigation/BottomNav.tsx
Copilot
AI
dismissed their stale review, a newer Copilot review was requested
November 5, 2026 16:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
With #494, the bottom nav fills the home indicator area with an empty 34px band under the icons. A floating capsule, like the iOS 26 tab bar, lets the content use the full screen and matches the Safari 26 toolbar.
Changes
common.tabs). The full labels stay as the accessible names.--bottom-nav-spacefor themainpadding and for sticky footers that must stay above the capsule.Screenshots
Prev. #490