Repository navigation
Conversation
Add a root AGENTS.md with the setup, validation, and project traps. Add local ESLint rules for route loaders without staleTime and for i18n selectors that read more than one key.
|
✅ No security or compliance issues detected. Reviewed everything up to 37e91fd. Security OverviewDetected Code Changes
|
📊 Build Bundle StatsThe latest build generated the following assets: |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The ESLint rule mishandles type-only wrappers, rejecting valid conditional selectors while accepting bare selectors that select no key, and needs corrected validation with regression coverage.
1 open issue
What changed in this PR
This PR documents repository setup and frontend conventions, and adds lint checks to help prevent the route-loader and i18n selector regressions described in #441 and #550.
Changes:
- Adds shared contributor guidance in
AGENTS.md. - Enables rules requiring route-loader
staleTimeand single-key i18n selectors. - Adds
RuleTestercoverage for both rules.
| File | Description |
|---|---|
src/governance-app-frontend/eslint.config.test.js |
Adds valid and invalid cases for both lint rules. |
src/governance-app-frontend/eslint.config.js |
Defines and enables the project-specific lint rules. |
AGENTS.md |
Documents setup, validation, and frontend development conventions. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The repository has no shared instructions, so its traps are known only to people who already hit them. A route loader without
staleTimebroke the mobile e2e run on #441, and a selector that picks between keys threw a revoked-proxy error on #550.Changes
AGENTS.mdwith the setup, the validation commands, the PR title types, and the frontend and vitest traps.governance/route-loader-stale-time, which requiresstaleTimeon acreateFileRoutethat has aloader.governance/i18n-single-key, which requires each$selector to read one key.eslint.config.test.jswithRuleTestercases for both rules.