Repository navigation
Conversation
Print the Orbit request URL and the draft release URL at the end of the script, in a message that is ready to paste.
|
✅ No security or compliance issues detected. Reviewed everything up to be4ff9e. Security OverviewDetected Code Changes
|
📊 Build Bundle StatsThe latest build generated the following assets: |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The release announcement incorrectly names nns-dapp instead of governance-app, so copying it would announce a release of the wrong application.
1 open issue
What changed in this PR
This PR updates the Governance App production release script to print a ready-to-copy announcement using the links created during the release process.
Changes:
- Captures the Orbit request URL from
dfx-orbitoutput. - Uses the draft release URL returned by
ghinstead of a tag-based link. - Prints a final announcement with proposal and release draft links.
| File | Description |
|---|---|
scripts/release-prod |
Captures release links and prints the release announcement. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After each production release, the announcement needs the Orbit link and the GitHub release draft link.
release-prodalready creates both, so it can print the message.Changes
release-prodthat prints the announcement with the Proposal and Release draft links.dfx-orbitoutput.gh, because the git tag does not exist until the release is published.