Repository navigation
Conversation
A Range header on an unchunked asset selected the wildcard fallback, and the HTTP gateway rejected the response with a 503. Slack link previews failed on each stored proposal page for this reason. Remove the header unless the asset is chunked.
|
✅ No security or compliance issues detected. Reviewed everything up to 74f6694. Security OverviewDetected Code Changes
|
📊 Build Bundle StatsThe latest build generated the following assets: |
Contributor
There was a problem hiding this comment.
🟢 Approved
The asset range-routing change has no active review issues blocking approval.
No open issues 🎉
What changed in this PR
This PR fixes asset routing for Range requests so unchunked assets, including proposal previews, return the correct certified response instead of the wildcard fallback.
Changes:
- Removes
Rangeheaders before serving unchunked assets. - Preserves range handling for chunked assets such as videos.
- Adds regression tests for full proposal-page responses and partial chunked-asset responses.
| File | Description |
|---|---|
src/governance-app-backend/src/assets.rs |
Filters range headers based on asset chunking and adds regression tests. |
Review effort: Balanced
yhabib
enabled auto-merge
November 7, 2026 12:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Slack shows no link card for most proposals. Slackbot sends
Range: bytes=0-32768, and on mainnet aRangeGET on a stored proposal page returns 503backend_response_verification. Only the first fetch of a page works, so 144742 got a card, and 144740 and 144743 did not.AssetRouterstores an asset under a byte range only if the asset is chunked. On any other asset,Rangeselects the wildcardindex.htmlfallback, and the gateway rejects it. The same 503 happens on/and/robots.txt.Changes
Rangeheader beforeserve_asset, unless the asset is chunked.Rangeon chunked assets, because the gateway uses it to fetch the later chunks ofcore-bg-original.mp4.Rangerequest on a proposal page and on a chunked asset.