Skip to content

Add DigraphMaximalQuotients - #959

Open
boriforizs wants to merge 1 commit into
digraphs:mainfrom
boriforizs:add-digraphs-maximal-quotients
Open

boriforizs wants to merge 1 commit into
digraphs:mainfrom
boriforizs:add-digraphs-maximal-quotients

Conversation

@boriforizs

Copy link
Copy Markdown

No description provided.

@mtorpey

mtorpey commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

A bit of a failure in the tests here, as you can see, e.g. at this link.

You'll notice in the tst files that there's a list of local variables at the top, and it looks like you need to add mq to that. Give it a try and see if you can get tests passing.

(You can add more commits to this PR by simply adding them to the branch and pushing.)

@mtorpey

mtorpey commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Other things to work on:

  • Add documentation for DigraphMaximalQuotients, in doc/attr.xml and an appropriate z-chap file. You can see what's done for other functions by looking through those.
  • Add a comment to your code to indicate the bit that is probably not optimal (comparing Bliss canonical reps).
  • Start work on a version that uses DigraphHash and see if it speeds things up.
  • Abstract out the more generic operation DigraphsUpToIsomorphism.

Hopefully this gives you some stuff to work on till next meeting. Thanks for emailing me!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants