This repository was archived by the owner on Sep 24, 2026. It is now read-only.
Repository navigation
Added 'realistic' test for events - #544
Merged
Merged
Conversation
ThierryBerger
marked this pull request as draft
June 25, 2024 14:50
ThierryBerger
force-pushed
the
events_test
branch
from
June 25, 2024 16:21
d828c80 to
ddc7511
Compare
ThierryBerger
commented
Jul 1, 2024
| env: | ||
| CARGO_TERM_COLOR: always | ||
| RUST_CACHE_KEY: rust-cache-20240617 | ||
| RUST_CACHE_KEY: rust-cache-20240626 |
Contributor
Author
There was a problem hiding this comment.
I'm not sure exactly why tests often go above disk space limits :/
sebcrozet
approved these changes
Jul 3, 2024
Co-authored-by: Sébastien Crozet <sebastien@crozet.re>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While attempting an ambitious refactor, I realized I broke a lot of things, events being one of them, so I added a test to make sure we don't break them in the future.
This pull request needs a polish pass, but I'm making it public so we can discuss the approach.
Also, time manipulation is a useful pattern which could use some love.