Prefer individual unexpected_cfgs allow over global one - #638
Closed
Urgau wants to merge 2 commits into
Closed
Conversation
ThierryBerger
approved these changes
May 29, 2024
ThierryBerger
left a comment
ThierryBerger
left a comment
Contributor
There was a problem hiding this comment.
Looks fine to me ; it's a pity we're losing the comment for context on the lint though
For the asmjs target drop, more context here: rust-lang/rust#117338
ThierryBerger
left a comment
ThierryBerger
left a comment
Contributor
There was a problem hiding this comment.
After playing a bit with it, I'm not sure if this makes sense to keep unexpected_cfgs = "allow" at all ?
Member
|
@Urgau Thank you for this PR! What is the benefit of allowing the lint in individual |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replace the global
#![allow(unexpected_cfgs)]over individual ones incrates/*, so that the main library still gets the benefits of the lint.This PR also remove obsolete asmjs cfg, since that target was removed some time ago from Rust.