Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on CircuitMess#19.
SpeedModifiernow uses a clamped Q16.16 0.5x-1.5x rate, maps the legacy midpoint (127) exactly to neutral, and exposes precise rate/get/nudge controls throughMixSystemwithout adding sync logic. Parameter changes converge within one 256-sample block; source swaps clear buffered old audio while preserving the requested/current rate. Pitch still changes with rate and is documented explicitly.Linear interpolation replaces nearest-neighbor resampling. A 24M-sample host microbenchmark measured 6.52 ns/sample nearest vs. 6.73 ns/sample linear (+0.21 ns/sample), while sine-reference mean absolute error dropped from 810.47 to 29.13 (96.4%). No allocation was added to
generate().Checks:
tests/run-speed-modifier-self-check.shcm:esp32:jaydArduino build: 1,026,274 bytes flash (28%), 44,464 bytes globals (13%)Out of scope: beat detection, phase sync, firmware UI, and key lock/time stretching.