fix: skip image enrichment without pages - #3875
dolfim-ibm merged 1 commit into
Conversation
Signed-off-by: debaditya <debaditya2005hait@gmail.com>
|
✅ DCO Check Passed Thanks @DebadityaHait, all your commits are properly signed off. 🎉 |
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
There was a problem hiding this comment.
I don't think this PR is solving the reported issue. PPTX still has pages but no page image.
@DebadityaHait can you please verify this?
|
Verified. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Issue resolved by this Pull Request:
Resolves #3867
Description
Skip image enrichment for native charts that have neither an embedded image nor page images, preventing
SimplePipelinefrom indexing an empty page list. The chart remains in the converted document.Checklist:
Tests:
uv run pytest tests/test_backend_pptx.py -quv run ruff format --check docling/models/base_model.py tests/test_backend_pptx.pyuv run ruff check docling/models/base_model.py tests/test_backend_pptx.py